Microblog (think Mastodon)−style attachments support merged into Lemmy

Append attachments to comments by flamingo-cant-draw · Pull Request #5143 · LemmyNet/lemmy
submitted by Aatube@kbin.melroy.org

github.com/LemmyNet/lemmy/pull/5143

Append attachments to comments by flamingo-cant-draw ?? Pull Request #5143 ?? LemmyNet/lemmy

115

Back to main discussion

Andrew

How does Piefed handle image attachments, btw?

For comments: not at all. If a Mastodon user tried to do what I did, with the inline image, nothing would show.

We could do what I think you've done, and regex the details of the attachment into ! [] () Markdown and add it to the text. There's also a DB relationship between comments and images that isn't used, but could be, I suppose.

I've never actually seen a Mastodon user try to add an image to something that ended up as a Lemmy comment, tbh, so it's not something I've thought too much about.

reply
4
flamingos-cant@feddit.uk
, edited

We could do what I think you’ve done, and regex the details of the attachment into ! [] ()

To be clear, this pull request doesn't use regex, it's just JSON deserialisation and string interpolation.

I’ve never actually seen a Mastodon user try to add an image to something that ended up as a Lemmy comment, tbh, so it’s not something I’ve thought too much about.

The pull request actually includes one, the main KDE account tags !kde@lemmy.kde.social and includes pictures in their threads regularly. It's just hard to tell from our side as you can't see what's missing.

reply
5
Andrew

Ah, great, thank you. It's been added as an Issue for PF now, with a link to this post, so that'll be handy.

(I was likely misusing the term 'regex').

reply
5